Yongjun Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11443 )
Change subject: IMPALA-6202. mod and % are not equivalent. ...................................................................... Patch Set 2: I'm thinking about a different approach now, say, we can probably simply convert a "mod" to "%" when doing the parsing, this way, all code used by "%" would be shared, and thus making them really equivalent. Thanks. -- To view, visit http://gerrit.cloudera.org:8080/11443 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib0067da04083859ffbf662a29007154461bea2ba Gerrit-Change-Number: 11443 Gerrit-PatchSet: 2 Gerrit-Owner: Yongjun Zhang <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: Yongjun Zhang <[email protected]> Gerrit-Comment-Date: Fri, 14 Sep 2018 23:37:23 +0000 Gerrit-HasComments: No
