Yongjun Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11443 )
Change subject: IMPALA-6202. mod and % are not equivalent. ...................................................................... Patch Set 3: Uploaded a quick v3 to prove concept, it seems to be a much better solution. The reason I'm looking for new solution is, the casting in the previous solution can fail for certain cases. That's the hole I was referring to. I will craft coding and probably add more tests later. One side note, this will change the behavior of "mod" for certain cases, thus may appear incompatible. Thanks. -- To view, visit http://gerrit.cloudera.org:8080/11443 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib0067da04083859ffbf662a29007154461bea2ba Gerrit-Change-Number: 11443 Gerrit-PatchSet: 3 Gerrit-Owner: Yongjun Zhang <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: Yongjun Zhang <[email protected]> Gerrit-Comment-Date: Sat, 15 Sep 2018 00:14:11 +0000 Gerrit-HasComments: No
