Yongjun Zhang has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11443 )
Change subject: IMPALA-6202. mod and % are not equivalent. ...................................................................... IMPALA-6202. mod and % are not equivalent. Currently typeof(9.9 % 3) is DECIMAL(2,1) and typeof(mod(9.9, 3)) is DECIMAL(4,1), it's expected that both to be DECIMAL(2,1). This jira fixes it by makeing mod and % equivalent. The solution is to replace "mod" with "%". Testing: Added unit tests and done real cluster testing. Change-Id: Ib0067da04083859ffbf662a29007154461bea2ba --- M fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java M testdata/workloads/functional-query/queries/QueryTest/decimal-exprs.test 3 files changed, 79 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/11443/3 -- To view, visit http://gerrit.cloudera.org:8080/11443 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib0067da04083859ffbf662a29007154461bea2ba Gerrit-Change-Number: 11443 Gerrit-PatchSet: 3 Gerrit-Owner: Yongjun Zhang <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: Yongjun Zhang <[email protected]>
