Yongjun Zhang has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11443 )
Change subject: IMPALA-6202. mod and % are not equivalent. ...................................................................... IMPALA-6202. mod and % are not equivalent. Currently typeof(9.9 % 3) is DECIMAL(2,1) and typeof(mod(9.9, 3)) is DECIMAL(4,1), it's expected that both to be DECIMAL(2,1). This jira fixes it for Decimal V2 mode. V1 behavior is left as is since the V1 mode will be dropped soon per IMPALA-4924. Testing: Added unit tests to cover the above mentioned two cases for both Decimal V1 and V2 mode, while the two cases are fixed in V2 mode, they remain different in V1 mode. Change-Id: Ib0067da04083859ffbf662a29007154461bea2ba --- M fe/src/main/java/org/apache/impala/analysis/Expr.java M fe/src/main/java/org/apache/impala/analysis/TypesUtil.java M testdata/workloads/functional-query/queries/QueryTest/decimal-exprs.test 3 files changed, 72 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/11443/2 -- To view, visit http://gerrit.cloudera.org:8080/11443 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib0067da04083859ffbf662a29007154461bea2ba Gerrit-Change-Number: 11443 Gerrit-PatchSet: 2 Gerrit-Owner: Yongjun Zhang <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]>
