Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14546 )
Change subject: IMPALA-9071: Fix wrong table path of transaction table created by CTAS ...................................................................... IMPALA-9071: Fix wrong table path of transaction table created by CTAS The previous patch of IMPALA-9071 assumes that all tables created by CTAS statement are non transactional table. This is wrong since CTAS statement can also specify tblproperties so can create transactional table. This patch fixs the hard coded external checking. Instead, we judge on whether the table is transactional. If not, it will be translated to external table by HMS. Tests: - Add coverage for creating transactional tables by CTAS. Change-Id: I4b585216e33e4f7962b19ae2351165288691eaf2 Reviewed-on: http://gerrit.cloudera.org:8080/14546 Reviewed-by: Joe McDonnell <[email protected]> Reviewed-by: Zoltan Borok-Nagy <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/compat-hive-2/java/org/apache/impala/compat/MetastoreShim.java M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java M fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java M tests/custom_cluster/test_custom_hive_configs.py 4 files changed, 49 insertions(+), 27 deletions(-) Approvals: Joe McDonnell: Looks good to me, but someone else must approve Zoltan Borok-Nagy: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/14546 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I4b585216e33e4f7962b19ae2351165288691eaf2 Gerrit-Change-Number: 14546 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
