David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15284 )
Change subject: IMPALA-9414: Support the 'Expect: 100-continue' http header ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/15284/1/shell/THttpClient.py File shell/THttpClient.py: http://gerrit.cloudera.org:8080/#/c/15284/1/shell/THttpClient.py@145 PS1, Line 145: def flush(self): Hmm. So, rather than copying the original file into our source tree, why do what was done in an earlier patch -- derive a child class in impala_client.py from the parent THttpClient (e.g., call it ImpalaThriftHttpClient), and then just completely override the flush() method? What's the benefit of doing it this way? http://gerrit.cloudera.org:8080/#/c/15284/1/shell/make_shell_tarball.sh File shell/make_shell_tarball.sh: http://gerrit.cloudera.org:8080/#/c/15284/1/shell/make_shell_tarball.sh@123 PS1, Line 123: cp ${SHELL_HOME}/util.py ${TARBALL_ROOT}/lib "${SHELL_HOME}/exceptions.py" http://gerrit.cloudera.org:8080/#/c/15284/1/shell/packaging/make_python_package.sh File shell/packaging/make_python_package.sh: http://gerrit.cloudera.org:8080/#/c/15284/1/shell/packaging/make_python_package.sh@59 PS1, Line 59: cp "${SHELL_HOME}/util.py" "${MODULE_LIB_DIR}" "${SHELL_HOME}/exceptions.py" http://gerrit.cloudera.org:8080/#/c/15284/1/shell/util.py File shell/util.py: http://gerrit.cloudera.org:8080/#/c/15284/1/shell/util.py@1 PS1, Line 1: # Licensed to the Apache Software Foundation (ASF) under one Well, now that you've started this, I think this file should actually be called exceptions.py, and we should probably move all of the exceptions here from wherever else they maybe scattered (maybe it's only impala_client.py). -- To view, visit http://gerrit.cloudera.org:8080/15284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4153968551acd58b25c7923c2ebf75ee29a7e76b Gerrit-Change-Number: 15284 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 25 Feb 2020 20:12:00 +0000 Gerrit-HasComments: Yes
