Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15284 )
Change subject: IMPALA-9414 (part 2): Support the 'Expect: 100-continue' http header ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/15284/4/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/15284/4/tests/shell/test_shell_commandline.py@859 PS4, Line 859: 20 After fixing the above error so that this test is actually running again, it started failing in Jenkins runs. As far as I can tell, the problem is really just that the shell is genuinely slower than this timeout for large query files. For comparison, it takes about 7 seconds running locally for me. I dug into it, and of that about 4 seconds are spent in parse_query_text, which uses some sqlparse functions to split the query text into multiple queries. About 2 seconds are spent in sqlparse.split() and another 2 seconds are spend in strip_comments() That seems like an unreasonable overhead for what its accomplishing. For the sake of getting this patch in, I would prefer to just extend the timeout for now, but we should probably think about how we can improve this, since otherwise impala-shell has pretty bad performance for even moderately large queries. I filed IMPALA-9436 -- To view, visit http://gerrit.cloudera.org:8080/15284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4153968551acd58b25c7923c2ebf75ee29a7e76b Gerrit-Change-Number: 15284 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Thu, 27 Feb 2020 21:34:41 +0000 Gerrit-HasComments: Yes
