Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15284 )
Change subject: IMPALA-9414 (part 2): Support the 'Expect: 100-continue' http header ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/15284/1/shell/make_shell_tarball.sh File shell/make_shell_tarball.sh: http://gerrit.cloudera.org:8080/#/c/15284/1/shell/make_shell_tarball.sh@123 PS1, Line 123: cp ${SHELL_HOME}/shell_exceptions.py ${TARBALL_ROOT}/lib > "${SHELL_HOME}/exceptions.py" Done http://gerrit.cloudera.org:8080/#/c/15284/1/shell/packaging/make_python_package.sh File shell/packaging/make_python_package.sh: http://gerrit.cloudera.org:8080/#/c/15284/1/shell/packaging/make_python_package.sh@59 PS1, Line 59: cp "${SHELL_HOME}/shell_exceptions.py" "${MODULE_LIB_DIR}" > "${SHELL_HOME}/exceptions.py" Done http://gerrit.cloudera.org:8080/#/c/15284/1/shell/util.py File shell/util.py: http://gerrit.cloudera.org:8080/#/c/15284/1/shell/util.py@1 PS1, Line 1: > Well, now that you've started this, I think this file should actually be ca So I ran into a problem with this because 'exceptions' is a built in python module already, so you can't do something like "from exceptions import RPCException". I solved it by naming the file "shell_exceptions" instead -- To view, visit http://gerrit.cloudera.org:8080/15284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4153968551acd58b25c7923c2ebf75ee29a7e76b Gerrit-Change-Number: 15284 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Thu, 27 Feb 2020 20:59:17 +0000 Gerrit-HasComments: Yes
