Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15284 )
Change subject: IMPALA-9414: Support the 'Expect: 100-continue' http header ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/15284/1/shell/THttpClient.py File shell/THttpClient.py: http://gerrit.cloudera.org:8080/#/c/15284/1/shell/THttpClient.py@145 PS1, Line 145: def flush(self): > Hmm. So, rather than copying the original file into our source tree, why do My prior understanding of python was that this wouldn't be possible due to the "__*" class variables being private. After some googling, I guess that's not really the case, and "private" variables in python is more of a guideline than an actual rule. So sure, I guess it could be done that way. It feels cleaner to me to do it this way, esp. since I suspect we'll want to make further, more significant changes to this class eventually, but its not a big deal. Either way, I wouldn't think that doing that would solve our python 3 compatibility issue, but then I don't really understand how python dependencies work. I suppose I could do it that way to get something in right now, and we could worry about the compatibility later. I'll at least put a patch together. http://gerrit.cloudera.org:8080/#/c/15284/1/shell/util.py File shell/util.py: http://gerrit.cloudera.org:8080/#/c/15284/1/shell/util.py@18 PS1, Line 18: class RPCException(Exception): > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/15284/1/shell/util.py@21 PS1, Line 21: d > flake8: E301 expected 1 blank line, found 0 Done -- To view, visit http://gerrit.cloudera.org:8080/15284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4153968551acd58b25c7923c2ebf75ee29a7e76b Gerrit-Change-Number: 15284 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Tue, 25 Feb 2020 20:40:58 +0000 Gerrit-HasComments: Yes
