Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 )
Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16446/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16446/1//COMMIT_MSG@20 PS1, Line 20: default catalog type is : 'hadoop.tables'. Is there any consideration behind making hadoop.tables the default? AFAIK hadoop.catalog gives more than hadoop.tables so let's consider making it as a default. But making one step forward, in the future we might want to introduce hive.catalog as well that works with S3 too so in the long run that should be the default in my opinion. -- To view, visit http://gerrit.cloudera.org:8080/16446 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1893c50a633ca22d4bca6726c9937b026f5d5ef Gerrit-Change-Number: 16446 Gerrit-PatchSet: 1 Gerrit-Owner: wangsheng <sky...@163.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 14 Sep 2020 16:32:50 +0000 Gerrit-HasComments: Yes