Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 )
Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table ...................................................................... Patch Set 2: (6 comments) Thanks for the changes! I have some minor ones but the patch in general is in a good shape. I'll let Zoltan to take a look also. http://gerrit.cloudera.org:8080/#/c/16446/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16446/2//COMMIT_MSG@21 PS2, Line 21: If you don't specify this property in your SQL, default catalog type is : 'hadoop.catalog'. I'd list the currently possible values ('hadoop.catalog', 'hadoop.table'). http://gerrit.cloudera.org:8080/#/c/16446/2//COMMIT_MSG@22 PS2, Line 22: And if you want to create external table, For me talking about external tables would be more readable in a separate paragraph. http://gerrit.cloudera.org:8080/#/c/16446/2//COMMIT_MSG@28 PS2, Line 28: nit: please avoid using tabs for indentation http://gerrit.cloudera.org:8080/#/c/16446/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test: http://gerrit.cloudera.org:8080/#/c/16446/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test@56 PS2, Line 56: TBLPROPERTIES('iceberg_table_name'='fake_db.fake_table'); Is it possible to create an external table using some invalid 'iceberg_table_name'? Is there such a scenario and what is expected if there is? http://gerrit.cloudera.org:8080/#/c/16446/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test: http://gerrit.cloudera.org:8080/#/c/16446/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test@191 PS2, Line 191: SELECT count(*) from hadoop_catalog_test_external I know that we can't write Iceberg tables at the moment but is there any way to extend these tests for non-external tables that use 'hadoop_catalog'? http://gerrit.cloudera.org:8080/#/c/16446/2/testdata/workloads/functional-query/queries/QueryTest/show-create-table.test File testdata/workloads/functional-query/queries/QueryTest/show-create-table.test: http://gerrit.cloudera.org:8080/#/c/16446/2/testdata/workloads/functional-query/queries/QueryTest/show-create-table.test@585 PS2, Line 585: TBLPROPERTIES('iceberg_file_format'='parquet', 'iceberg_catalog'='hadoop.catalog') Could you also add test coverage here for the default value of 'iceberg_catalog'? -- To view, visit http://gerrit.cloudera.org:8080/16446 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1893c50a633ca22d4bca6726c9937b026f5d5ef Gerrit-Change-Number: 16446 Gerrit-PatchSet: 2 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Thu, 17 Sep 2020 16:32:10 +0000 Gerrit-HasComments: Yes
