Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 )
Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table ...................................................................... Patch Set 3: (7 comments) Thanks for your work again! This also makes it easier for us to add HiveCatalog later on. I only found some minor issues. http://gerrit.cloudera.org:8080/#/c/16446/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16446/3//COMMIT_MSG@29 PS3, Line 29: _ nit: Shouldn't we use 'iceberg.table_name' just like 'kudu.table_name'. In the above example we use a dot for specifying the catalog, i.e. 'iceberg.catalog'. This is also what Hiveberg does, so I prefer the dot notation to be consistent. http://gerrit.cloudera.org:8080/#/c/16446/3/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/16446/3/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@69 PS3, Line 69: iceberg_file_format If that's not too much pain, maybe we should also change it to "iceberg.file_format" for consistency. http://gerrit.cloudera.org:8080/#/c/16446/3/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@72 PS3, Line 72: iceberg_catalog In the commit message you mention "iceberg.catalog", not "iceberg_catalog". Hiveberg also uses the dot syntax: https://github.com/ExpediaGroup/hiveberg For Kudu options we also use the dot syntax, so maybe we should also use the dot syntax for Iceberg properties. http://gerrit.cloudera.org:8080/#/c/16446/3/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/16446/3/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java@78 PS3, Line 78: // Each table id increase from zero : iThreadLocal.set(0); You already set it at L57. http://gerrit.cloudera.org:8080/#/c/16446/3/fe/src/main/java/org/apache/impala/util/IcebergUtil.java File fe/src/main/java/org/apache/impala/util/IcebergUtil.java: http://gerrit.cloudera.org:8080/#/c/16446/3/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@102 PS3, Line 102: "default" nit: probably 'Catalog.DEFAULT_DB' should be used http://gerrit.cloudera.org:8080/#/c/16446/3/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@149 PS3, Line 149: "default." nit: Catalog.DEFAULT_DB http://gerrit.cloudera.org:8080/#/c/16446/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test: http://gerrit.cloudera.org:8080/#/c/16446/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test@221 PS3, Line 221: where event_time > to_timestamp('2020-01-01 09:00:00','yyyy-MM-dd HH:mm:ss') Please add "SET TIMEZONE=UTC;" to tests that involve timestamps. For further info please see IMPALA-10158. -- To view, visit http://gerrit.cloudera.org:8080/16446 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1893c50a633ca22d4bca6726c9937b026f5d5ef Gerrit-Change-Number: 16446 Gerrit-PatchSet: 3 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Mon, 21 Sep 2020 11:58:48 +0000 Gerrit-HasComments: Yes
