wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 )
Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table ...................................................................... Patch Set 2: (8 comments) Hi Gabor, thanks for your review, I've already modify code. http://gerrit.cloudera.org:8080/#/c/16446/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16446/1//COMMIT_MSG@20 PS1, Line 20: og'); : If you don't spe > Is there any consideration behind making hadoop.tables the default? AFAIK h Since we only supported HadoopTables before, I use this as default catalog type, there is no more reasons. You are right, hadoop.catalog gives more than hadoop.tables, so if necessary, I will use hadoop.catalog as default catalog type and modified related files. http://gerrit.cloudera.org:8080/#/c/16446/1/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/16446/1/common/thrift/CatalogObjects.thrift@96 PS1, Line 96: identified > nit: typo Done http://gerrit.cloudera.org:8080/#/c/16446/1/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/16446/1/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@244 PS1, Line 244: at getIcebergFile > I find it confusing that IcebergUtil also has a function with the same name Done http://gerrit.cloudera.org:8080/#/c/16446/1/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/16446/1/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@71 PS1, Line 71: // Iceberg catalog type key in tblproperties > nit: pls add comment similarly to ICEBERG_FILE_FORMAT above. Done http://gerrit.cloudera.org:8080/#/c/16446/1/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/16446/1/fe/src/main/java/org/apache/impala/catalog/local/LocalIcebergTable.java@111 PS1, Line 111: return tableParams_.icebergCatalog_; : } : : @ > FeIcebergTable has 2 implementations, this class and IcebergTable. Both hav I add icebergCatalog_ in TableParams in LocalIcebergTable.java, and return 'tableParams_.icebergCatalog_' in getIcebergCatalog(), just like getIcebergTableLocation(). I found that this way is also suitable for getIcebergFileFormat(), I'm not sure to modify in this patch. http://gerrit.cloudera.org:8080/#/c/16446/1/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java File fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java: http://gerrit.cloudera.org:8080/#/c/16446/1/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@a93 PS1, Line 93: > As I see this patch also contains some modifications related to Iceberg tab Done http://gerrit.cloudera.org:8080/#/c/16446/1/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/16446/1/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java@54 PS1, Line 54: TIcebergCatalo > Using TIcebergCatalog as a param would be easier to understand what is the Done http://gerrit.cloudera.org:8080/#/c/16446/1/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java@63 PS1, Line 63: Preconditions.checkArgument(catalog == TIcebergCatalog.HADOOP_TABLES); > Would worth a Preconditions check in the else branch that icebergCatalog == Done -- To view, visit http://gerrit.cloudera.org:8080/16446 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1893c50a633ca22d4bca6726c9937b026f5d5ef Gerrit-Change-Number: 16446 Gerrit-PatchSet: 2 Gerrit-Owner: wangsheng <sky...@163.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: wangsheng <sky...@163.com> Gerrit-Comment-Date: Tue, 15 Sep 2020 13:39:06 +0000 Gerrit-HasComments: Yes
