wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 )
Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table ...................................................................... Patch Set 4: (7 comments) I've already rename two new properties to: 'iceberg.catalog' and 'iceberg.table_name', I'm not sure if this is appropriate to rename 'iceberg_file_format' to 'iceberg.file_format' in this patch. http://gerrit.cloudera.org:8080/#/c/16446/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16446/3//COMMIT_MSG@29 PS3, Line 29: . > nit: Shouldn't we use 'iceberg.table_name' just like 'kudu.table_name'. In Done http://gerrit.cloudera.org:8080/#/c/16446/3/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/16446/3/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@69 PS3, Line 69: iceberg_file_format > If that's not too much pain, maybe we should also change it to "iceberg.fil Shall we change this property name in this patch? Maybe in another patch is better? http://gerrit.cloudera.org:8080/#/c/16446/3/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@72 PS3, Line 72: iceberg.catalog > In the commit message you mention "iceberg.catalog", not "iceberg_catalog". Done http://gerrit.cloudera.org:8080/#/c/16446/3/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/16446/3/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java@78 PS3, Line 78: // Each table id increase from zero : HadoopCatalog catalo > You already set it at L57. Done http://gerrit.cloudera.org:8080/#/c/16446/3/fe/src/main/java/org/apache/impala/util/IcebergUtil.java File fe/src/main/java/org/apache/impala/util/IcebergUtil.java: http://gerrit.cloudera.org:8080/#/c/16446/3/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@102 PS3, Line 102: { > nit: probably 'Catalog.DEFAULT_DB' should be used Done http://gerrit.cloudera.org:8080/#/c/16446/3/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@149 PS3, Line 149: .contains( > nit: Catalog.DEFAULT_DB Done http://gerrit.cloudera.org:8080/#/c/16446/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test: http://gerrit.cloudera.org:8080/#/c/16446/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test@221 PS3, Line 221: SELECT count(*) from hadoop_catalog_test_external > Please add "SET TIMEZONE=UTC;" to tests that involve timestamps. For furthe Done -- To view, visit http://gerrit.cloudera.org:8080/16446 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1893c50a633ca22d4bca6726c9937b026f5d5ef Gerrit-Change-Number: 16446 Gerrit-PatchSet: 4 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Mon, 21 Sep 2020 12:56:24 +0000 Gerrit-HasComments: Yes
