Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16446 )
Change subject: IMPALA-10164: Supporting HadoopCatalog for Iceberg table ...................................................................... Patch Set 4: Code-Review+1 (2 comments) Thanks for applying the changes! http://gerrit.cloudera.org:8080/#/c/16446/3/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/16446/3/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@69 PS3, Line 69: iceberg_file_format > Shall we change this property name in this patch? Maybe in another patch is I don't have a strong opinion on that, whichever works best for you. http://gerrit.cloudera.org:8080/#/c/16446/3/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/16446/3/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java@78 PS3, Line 78: // Each table id increase from zero : HadoopCatalog catalo > Done Maybe these functions should be private as well. I guess we only want them to be called from the public createTable() at L54. Probably we should also rename them to createTableByHadoopTables() and createTableByHadoopCatalog(). -- To view, visit http://gerrit.cloudera.org:8080/16446 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1893c50a633ca22d4bca6726c9937b026f5d5ef Gerrit-Change-Number: 16446 Gerrit-PatchSet: 4 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Mon, 21 Sep 2020 13:26:49 +0000 Gerrit-HasComments: Yes
