Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/16542 )
Change subject: IMPALA-10210: Skip Authentication for connection from a trusted domain ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16542/1/be/src/transport/THttpServer.cpp File be/src/transport/THttpServer.cpp: http://gerrit.cloudera.org:8080/#/c/16542/1/be/src/transport/THttpServer.cpp@195 PS1, Line 195: transport_->getOrigin() for connections originating from the localhost, this returns "localhost" which is not a valid IP and fails the check even if trusted_domain is set to localhost. Do you think we should add a special case to check for domain names or only "localhost" in particular? -- To view, visit http://gerrit.cloudera.org:8080/16542 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09234078e2314dbc3177d0e869ae028e216ca699 Gerrit-Change-Number: 16542 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Sat, 03 Oct 2020 01:43:01 +0000 Gerrit-HasComments: Yes
