Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16542 )
Change subject: IMPALA-10210: Skip Authentication for connection from a trusted domain ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/16542/3/be/src/rpc/authentication-util.cc File be/src/rpc/authentication-util.cc: http://gerrit.cloudera.org:8080/#/c/16542/3/be/src/rpc/authentication-util.cc@178 PS3, Line 178: VLOG(2) << "Unable to parse origin address. Error: " << s.ToString(); Not sure if this is really an error? I think this is just handling the case where 'origin' is a hostname instead of an IP, which is expected in the case of trusted_domain_use_xff_header=false I think http://gerrit.cloudera.org:8080/#/c/16542/3/be/src/rpc/authentication-util.cc@202 PS3, Line 202: std::size_t colon = decoded.find(':'); I guess we're requiring that in the trusted domain case the Auth header is encoded with a ':' and any password, rather than just being a username? Might want to document that, eg. with the --trusted_domain flag info -- To view, visit http://gerrit.cloudera.org:8080/16542 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09234078e2314dbc3177d0e869ae028e216ca699 Gerrit-Change-Number: 16542 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Thu, 22 Oct 2020 22:06:04 +0000 Gerrit-HasComments: Yes
