Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16542 )
Change subject: IMPALA-10210: Skip Authentication for connection from a trusted domain ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/16542/1/be/src/rpc/authentication-util.cc File be/src/rpc/authentication-util.cc: http://gerrit.cloudera.org:8080/#/c/16542/1/be/src/rpc/authentication-util.cc@181 PS1, Line 181: s = sock_addr.LookupHostname(&host_name); Is there any performance problems with doing a reverse dns lookup on every request? http://gerrit.cloudera.org:8080/#/c/16542/1/be/src/transport/THttpServer.cpp File be/src/transport/THttpServer.cpp: http://gerrit.cloudera.org:8080/#/c/16542/1/be/src/transport/THttpServer.cpp@195 PS1, Line 195: transport_->getOrigin() > for connections originating from the localhost, this returns "localhost" wh Does this ever return an IP address? From looking at the code for TSocket, it seems like this will always return a hostname, in which case of course we should probably handle all hostnames, not just localhost. http://gerrit.cloudera.org:8080/#/c/16542/1/be/src/transport/THttpServer.cpp@206 PS1, Line 206: // Try authenticating with cookies first. This is outdated now http://gerrit.cloudera.org:8080/#/c/16542/1/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/16542/1/be/src/util/webserver.cc@599 PS1, Line 599: // Try authenticating with a cookie first, if enabled. outdated -- To view, visit http://gerrit.cloudera.org:8080/16542 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09234078e2314dbc3177d0e869ae028e216ca699 Gerrit-Change-Number: 16542 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Tue, 06 Oct 2020 17:59:02 +0000 Gerrit-HasComments: Yes
