Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/16542 )
Change subject: IMPALA-10210: Skip Authentication for connection from a trusted domain ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/16542/1/be/src/rpc/authentication-util.cc File be/src/rpc/authentication-util.cc: http://gerrit.cloudera.org:8080/#/c/16542/1/be/src/rpc/authentication-util.cc@181 PS1, Line 181: host_name = host_n_port[0]; > Is there any performance problems with doing a reverse dns lookup on every As discussed offline, to address this I added in support for returning and using cookies after a successful auth attempt. http://gerrit.cloudera.org:8080/#/c/16542/1/be/src/transport/THttpServer.cpp File be/src/transport/THttpServer.cpp: http://gerrit.cloudera.org:8080/#/c/16542/1/be/src/transport/THttpServer.cpp@195 PS1, Line 195: alue, we ignore it rath > Does this ever return an IP address? From looking at the code for TSocket, Yes TSocket always returns a hostname, so made changes to handle that case too. http://gerrit.cloudera.org:8080/#/c/16542/1/be/src/transport/THttpServer.cpp@206 PS1, Line 206: > This is outdated now moved this above the trusted auth check http://gerrit.cloudera.org:8080/#/c/16542/1/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/16542/1/be/src/util/webserver.cc@599 PS1, Line 599: request_info->remote_user = strdup(username.c_st > outdated moved this above the trusted auth check -- To view, visit http://gerrit.cloudera.org:8080/16542 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09234078e2314dbc3177d0e869ae028e216ca699 Gerrit-Change-Number: 16542 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Mon, 19 Oct 2020 23:12:51 +0000 Gerrit-HasComments: Yes
