Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/16542 )
Change subject: IMPALA-10210: Skip Authentication for connection from a trusted domain ...................................................................... Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/16542/2/be/src/rpc/authentication-util.h File be/src/rpc/authentication-util.h: http://gerrit.cloudera.org:8080/#/c/16542/2/be/src/rpc/authentication-util.h@40 PS2, Line 40: a comm > comma separated Done http://gerrit.cloudera.org:8080/#/c/16542/2/be/src/rpc/authentication-util.h@40 PS2, Line 40: without a port, picks the : // left > what's the rationale for only checking the first one? added the rationale http://gerrit.cloudera.org:8080/#/c/16542/2/be/src/rpc/authentication-util.h@48 PS2, Line 48: token > nit: an error Done http://gerrit.cloudera.org:8080/#/c/16542/2/be/src/util/webserver.h File be/src/util/webserver.h: http://gerrit.cloudera.org:8080/#/c/16542/2/be/src/util/webserver.h@201 PS2, Line 201: const std:: > const&? Done http://gerrit.cloudera.org:8080/#/c/16542/2/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/16542/2/be/src/util/webserver.cc@610 PS2, Line 610: // checking for cookie to avoid subsequent reverse DNS lookups which can be > Might be good to mention that we're doing this after checking cookies to av Done http://gerrit.cloudera.org:8080/#/c/16542/2/common/thrift/metrics.json File common/thrift/metrics.json: http://gerrit.cloudera.org:8080/#/c/16542/2/common/thrift/metrics.json@1299 PS2, Line 1299: ", > I wonder if "Failure" is too strong of a word here and below, since this wi Yea i agree with just removing the failure metric, its just adding noise -- To view, visit http://gerrit.cloudera.org:8080/16542 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09234078e2314dbc3177d0e869ae028e216ca699 Gerrit-Change-Number: 16542 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Thu, 22 Oct 2020 19:39:33 +0000 Gerrit-HasComments: Yes
