Hello Thomas Tauber-Marshall, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16542
to look at the new patch set (#4).
Change subject: IMPALA-10210: Skip Authentication for connection from a trusted
domain
......................................................................
IMPALA-10210: Skip Authentication for connection from a trusted domain
Adds the ability to skip authentication for connection requests
originating from a trusted domain over the hs2 http endpoint and
the http webserver endpoint. The trusted domain can be specified
using the newly added "--trusted_domain" startup flag. Additionally,
if the startup flag "--trusted_domain_use_xff_header" is set to true,
impala will switch to using the 'X-Forwarded-For' HTML header to
extract the origin address while attempting to check if the connection
originated from a trusted domain.
Other highlights:
- This still requires the client to specify a username via a basic
auth header.
- To avoid looking up hostname for every http request, a cookie is
returned on the first auth attempt which will then be subsequently
used for further communication on the same connection.
Testing:
Added tests for both the hs2 http endpoint and the webserver http endpoint
Change-Id: I09234078e2314dbc3177d0e869ae028e216ca699
---
M be/src/rpc/CMakeLists.txt
R be/src/rpc/authentication-util.cc
R be/src/rpc/authentication-util.h
M be/src/rpc/authentication.cc
M be/src/transport/THttpServer.cpp
M be/src/transport/THttpServer.h
M be/src/util/webserver.cc
M be/src/util/webserver.h
M common/thrift/metrics.json
M fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java
M fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java
11 files changed, 422 insertions(+), 46 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/16542/4
--
To view, visit http://gerrit.cloudera.org:8080/16542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I09234078e2314dbc3177d0e869ae028e216ca699
Gerrit-Change-Number: 16542
Gerrit-PatchSet: 4
Gerrit-Owner: Bikramjeet Vig <[email protected]>
Gerrit-Reviewer: Bikramjeet Vig <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
