Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19377 )

Change subject: IMPALA-11786: Preserve memory for codegen cache
......................................................................


Patch Set 1: Code-Review+1

This seems fair. I have some concerns about setting aside 20% of initial memory 
potentially impacting customers that were expecting their existing queries to 
continue working. I'm not sure what default memory configuration looks like 
though.


--
To view, visit http://gerrit.cloudera.org:8080/19377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebdc04ba1b91578d74684209a11c815225b8505a
Gerrit-Change-Number: 19377
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Qifan Chen <[email protected]>
Gerrit-Comment-Date: Mon, 19 Dec 2022 17:38:41 +0000
Gerrit-HasComments: No

Reply via email to