Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/19377 )
Change subject: IMPALA-11786: Preserve memory for codegen cache ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Looks good! http://gerrit.cloudera.org:8080/#/c/19377/1/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: http://gerrit.cloudera.org:8080/#/c/19377/1/be/src/runtime/exec-env.cc@337 PS1, Line 337: is_percent > If the is_percent is true, the codegen_cache_capacity should be 0 because r I see. Maybe add a DCHECK(!is_percent) here. -- To view, visit http://gerrit.cloudera.org:8080/19377 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebdc04ba1b91578d74684209a11c815225b8505a Gerrit-Change-Number: 19377 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 22 Dec 2022 15:29:41 +0000 Gerrit-HasComments: Yes
