Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/19377 )
Change subject: IMPALA-11786: Preserve memory for codegen cache ...................................................................... Patch Set 1: (6 comments) Looks good to me! http://gerrit.cloudera.org:8080/#/c/19377/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19377/1//COMMIT_MSG@15 PS1, Line 15: admit nit. admission http://gerrit.cloudera.org:8080/#/c/19377/1//COMMIT_MSG@16 PS1, Line 16: preserve nit. preserving http://gerrit.cloudera.org:8080/#/c/19377/1//COMMIT_MSG@17 PS1, Line 17: and treat nit. by treating http://gerrit.cloudera.org:8080/#/c/19377/1//COMMIT_MSG@17 PS1, Line 17: since nit. from http://gerrit.cloudera.org:8080/#/c/19377/1/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: http://gerrit.cloudera.org:8080/#/c/19377/1/be/src/runtime/exec-env.cc@337 PS1, Line 337: is_percent Do we need to check the value of is_percent after the call? http://gerrit.cloudera.org:8080/#/c/19377/1/tests/custom_cluster/test_executor_groups.py File tests/custom_cluster/test_executor_groups.py: http://gerrit.cloudera.org:8080/#/c/19377/1/tests/custom_cluster/test_executor_groups.py@591 PS1, Line 591: 20% It would be better to calculate the 3.2GB from 4Gb and 20%, so that one can specify 10% or 30% to fine tune the size of the codegen cache for a workload. -- To view, visit http://gerrit.cloudera.org:8080/19377 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebdc04ba1b91578d74684209a11c815225b8505a Gerrit-Change-Number: 19377 Gerrit-PatchSet: 1 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Comment-Date: Tue, 20 Dec 2022 14:50:52 +0000 Gerrit-HasComments: Yes
