Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19377 )
Change subject: IMPALA-11786: Preserve memory for codegen cache ...................................................................... Patch Set 2: (6 comments) Thanks Qifan and Michael. I think the change could affect some existing queries by taking away memory from admission control, but the change is necessary, and the user can disable the codegen cache or lower the value if needs to resume. http://gerrit.cloudera.org:8080/#/c/19377/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19377/1//COMMIT_MSG@15 PS1, Line 15: admis > nit. admission Done http://gerrit.cloudera.org:8080/#/c/19377/1//COMMIT_MSG@16 PS1, Line 16: preservi > nit. preserving Done http://gerrit.cloudera.org:8080/#/c/19377/1//COMMIT_MSG@17 PS1, Line 17: nd treati > nit. by treating Done http://gerrit.cloudera.org:8080/#/c/19377/1//COMMIT_MSG@17 PS1, Line 17: from > nit. from Done http://gerrit.cloudera.org:8080/#/c/19377/1/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: http://gerrit.cloudera.org:8080/#/c/19377/1/be/src/runtime/exec-env.cc@337 PS1, Line 337: is_percent > Do we need to check the value of is_percent after the call? If the is_percent is true, the codegen_cache_capacity should be 0 because relative_reference is 0, then the codegen cache will be disabled. I think for now we don't support percentage for codegen cache, just like the buffer pool limit below. http://gerrit.cloudera.org:8080/#/c/19377/1/tests/custom_cluster/test_executor_groups.py File tests/custom_cluster/test_executor_groups.py: http://gerrit.cloudera.org:8080/#/c/19377/1/tests/custom_cluster/test_executor_groups.py@591 PS1, Line 591: 20% > It would be better to calculate the 3.2GB from 4Gb and 20%, so that one can Added a calculation. -- To view, visit http://gerrit.cloudera.org:8080/19377 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebdc04ba1b91578d74684209a11c815225b8505a Gerrit-Change-Number: 19377 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 20 Dec 2022 23:41:56 +0000 Gerrit-HasComments: Yes
