Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19377 )
Change subject: IMPALA-11786: Preserve memory for codegen cache ...................................................................... Patch Set 3: Code-Review+1 The code looks good to me, but similarly to Michael I am also concerned about using 20% of the memory for codegen. -- To view, visit http://gerrit.cloudera.org:8080/19377 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebdc04ba1b91578d74684209a11c815225b8505a Gerrit-Change-Number: 19377 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 03 Jan 2023 15:51:29 +0000 Gerrit-HasComments: No
