Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/19377 )
Change subject: IMPALA-11786: Preserve memory for codegen cache ...................................................................... Patch Set 3: It may be a good idea to test a good default value <D> (say 10%) with a suitable workload such as tpcds. Basically, a minimal value that can help achieve the most benefit of the cache. In the long run, it seems a good idea to implement a caching strategy (i.e. removal of old items) so that the cache works well even configured with less than optimal threshold value <D>. -- To view, visit http://gerrit.cloudera.org:8080/19377 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebdc04ba1b91578d74684209a11c815225b8505a Gerrit-Change-Number: 19377 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 04 Jan 2023 00:08:05 +0000 Gerrit-HasComments: No
