Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19763 )
Change subject: IMPALA-11915: Support graphical plan exports in the WebUI ...................................................................... Patch Set 2: (3 comments) Looks pretty good! http://gerrit.cloudera.org:8080/#/c/19763/2/www/query_plan.tmpl File www/query_plan.tmpl: http://gerrit.cloudera.org:8080/#/c/19763/2/www/query_plan.tmpl@60 PS2, Line 60: <input type="button" class="btn btn-primary" style="font-size:16px;" data-toggle="modal" value="Export Plan" data-target="#export_modal" role="button"/> nit: let's try to keep each line width in 90 characters. http://gerrit.cloudera.org:8080/#/c/19763/2/www/query_plan.tmpl@78 PS2, Line 78: <input id="export_filename" class="form-control-sm" type="text"/> Can we add a default file name using the query id, e.g. "344a474634044b88_36e074d800000000_plan" (replace colon with underscore and add "_plan" suffix)? http://gerrit.cloudera.org:8080/#/c/19763/2/www/query_plan.tmpl@84 PS2, Line 84: <a id="export_link" class="btn btn-primary" data-dismiss="modal" href="" role="button">Export</a> nit: wrap this long line as well -- To view, visit http://gerrit.cloudera.org:8080/19763 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1bd549318e220419ba3ee40be05f3671a9f1d8d9 Gerrit-Change-Number: 19763 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 19 Apr 2023 03:02:07 +0000 Gerrit-HasComments: Yes
