Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/19763 )
Change subject: IMPALA-11915: Support graphical plan exports in the WebUI ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/19763/2/www/query_plan.tmpl File www/query_plan.tmpl: http://gerrit.cloudera.org:8080/#/c/19763/2/www/query_plan.tmpl@60 PS2, Line 60: <input type="button" class="btn btn-primary" style="font-size:16px;" data-toggle="modal" value="Export Plan" data-target="#export_modal" role="button"/> > The button has been enclosed in a seperate <label> tag now. The label tag is only useful if it provides context for the input. The following layout would make this feature more consistent with the Profile download page without being too intrusive on the layout. <TABLE WIDTH=100%><TR> <TD><h3>Plan</h3></TD> <TD ALIGN=RIGHT><label>Download (Available Formats): <input type="button" class="btn btn-primary" data-toggle="modal" value="HTML" data-target="#export_modal" role="button"/> </label> </TD></TR></TABLE> http://gerrit.cloudera.org:8080/#/c/19763/2/www/query_plan.tmpl@78 PS2, Line 78: <input id="export_filename" class="form-control-sm" type="text"/> > The mustache template library does not support regex to directly replace th Firefox replaces with space which is undesirable. Please replace : with _ using javascript. http://gerrit.cloudera.org:8080/#/c/19763/2/www/query_plan.tmpl@263 PS2, Line 263: var html_blob = new Blob([`<!DOCTYPE html><body>`,svg_style.outerHTML, > The font style to has been now included for all the `.nodes`. This should p Node text looks good now but edge text is still in default font. -- To view, visit http://gerrit.cloudera.org:8080/19763 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1bd549318e220419ba3ee40be05f3671a9f1d8d9 Gerrit-Change-Number: 19763 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Tue, 25 Apr 2023 15:39:57 +0000 Gerrit-HasComments: Yes
