Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/19763 )
Change subject: IMPALA-11915: Support graphical plan exports in the WebUI ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/19763/2/www/query_plan.tmpl File www/query_plan.tmpl: http://gerrit.cloudera.org:8080/#/c/19763/2/www/query_plan.tmpl@60 PS2, Line 60: <input type="button" class="btn btn-primary" style="font-size:16px;" data-toggle="modal" value="Export Plan" data-target="#export_modal" role="button"/> > nit: let's try to keep each line width in 90 characters. This should be outside of the existing <label> tags since those are implicitly associated with the checkbox. If you put the <input> inside the <H3> line above, it can share the line with the header which looks cleaner. http://gerrit.cloudera.org:8080/#/c/19763/2/www/query_plan.tmpl@263 PS2, Line 263: var html_blob = new Blob([`<!DOCTYPE html><body>`,svg_style.outerHTML, We need to preserve the font and possibly other style elements. Otherwise the text in the exported SVG may be covered or hard to read. Noticed this testing patch on Linux Firefox. Adding query_id as a title and header would be useful too. -- To view, visit http://gerrit.cloudera.org:8080/19763 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1bd549318e220419ba3ee40be05f3671a9f1d8d9 Gerrit-Change-Number: 19763 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 24 Apr 2023 15:48:04 +0000 Gerrit-HasComments: Yes
