Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/19763 )
Change subject: IMPALA-11915: Support graphical plan exports in the WebUI ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/19763/2/www/query_plan.tmpl File www/query_plan.tmpl: http://gerrit.cloudera.org:8080/#/c/19763/2/www/query_plan.tmpl@60 PS2, Line 60: <input type="button" class="btn btn-primary" style="font-size:16px;" data-toggle="modal" value="Export Plan" data-target="#export_modal" role="button"/> > This should be outside of the existing <label> tags since those are implici The button has been enclosed in a seperate <label> tag now. This may be a better approach. But, I can place it withing the h3 tag, if required. http://gerrit.cloudera.org:8080/#/c/19763/2/www/query_plan.tmpl@78 PS2, Line 78: <input id="export_filename" class="form-control-sm" type="text"/> > Can we add a default file name using the query id, e.g. "344a474634044b88_3 The mustache template library does not support regex to directly replace the ':' colon inline. But, javascript code can be added to do the same. As recent filesystems do not cause problems with ':', this should not be a problem. Also, most browsers will replace it with other characters. http://gerrit.cloudera.org:8080/#/c/19763/2/www/query_plan.tmpl@84 PS2, Line 84: <a id="export_link" class="btn btn-primary" data-dismiss="modal" href="" role="button">Export</a> > nit: wrap this long line as well Done http://gerrit.cloudera.org:8080/#/c/19763/2/www/query_plan.tmpl@263 PS2, Line 263: var html_blob = new Blob([`<!DOCTYPE html><body>`,svg_style.outerHTML, > We need to preserve the font and possibly other style elements. Otherwise t The font style to has been now included for all the `.nodes`. This should provide compatibility across the browsers. The header has also been added with appropriate styling. -- To view, visit http://gerrit.cloudera.org:8080/19763 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1bd549318e220419ba3ee40be05f3671a9f1d8d9 Gerrit-Change-Number: 19763 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Tue, 25 Apr 2023 13:30:18 +0000 Gerrit-HasComments: Yes
