Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19763 )
Change subject: IMPALA-11915: Support graphical plan exports in the WebUI ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/19763/2/www/query_plan.tmpl File www/query_plan.tmpl: http://gerrit.cloudera.org:8080/#/c/19763/2/www/query_plan.tmpl@78 PS2, Line 78: > Firefox replaces with space which is undesirable. Please replace : with _ u Ah, I just realized the colon is replaced by browsers and Chrome replaces it with _. In the download link of profiles, we just use the query id: https://github.com/apache/impala/blob/0a42185d17164af0c855647de25f1bc87f33ee71/www/query_profile.tmpl#L38 <a style="font-size:16px;" class="btn btn-primary" href="{{ __common__.host-url }}/query_profile_plain_text?query_id={{query_id}}" download="profile_{{query_id}}">Text</a> So I think this can be a separate improvement if you find it's complex. We can have a separate patch adding javascript to normalize these file names. -- To view, visit http://gerrit.cloudera.org:8080/19763 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1bd549318e220419ba3ee40be05f3671a9f1d8d9 Gerrit-Change-Number: 19763 Gerrit-PatchSet: 3 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Thu, 27 Apr 2023 01:52:35 +0000 Gerrit-HasComments: Yes
