Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20145 )
Change subject: IMPALA-12256: Fix DDLs losing create event ids in reloading partitions ...................................................................... Patch Set 6: Code-Review+1 (1 comment) Thanks for addressing my previous comments Quanlong! I do not have any other suggestion. http://gerrit.cloudera.org:8080/#/c/20145/4/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/20145/4/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@2904 PS4, Line 2904: partBuilder.setCreateEventId(oldPartition.getCreateEventId()); : partBuilder.setLastCompactionId(oldPartition.getLastCompactionId()); > 1. The lastRefreshEventId is set below at line 2907. Its source value is fe Thanks for the explanation Quanlong! Yeah. You are correct. We do not need to use the 'lastRefreshEventId_' from 'oldPartition' since 'latestEventId' is always higher/fresher and I just realized that even when we are processing a non-self INSERT event, we still update the field of 'lastRefreshEventId_' with the event ID of this INSERT event. -- To view, visit http://gerrit.cloudera.org:8080/20145 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I052faa093bda69fb16db0d424c1478bba103dad9 Gerrit-Change-Number: 20145 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Mon, 03 Jul 2023 20:57:56 +0000 Gerrit-HasComments: Yes
