Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20145 )
Change subject: IMPALA-12256: Fix DDLs losing create event ids in reloading partitions ...................................................................... Patch Set 6: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/20145/6/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/20145/6/tests/custom_cluster/test_events_custom_configs.py@846 PS6, Line 846: "alter table %s.part partition(p=0) set location '/tmp'" % unique_database, Can you add a few more comments to the test? I found it a bit confusing. If I understand correctly some of these DDLs would lead to events that cannot be skipped if they were done by another component, but Impala will detect them as self event and skip them. Meanwhile the self event logic doesn't handle drop partitions. Probably it would be useful to add some notes on why different events are skipped. -- To view, visit http://gerrit.cloudera.org:8080/20145 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I052faa093bda69fb16db0d424c1478bba103dad9 Gerrit-Change-Number: 20145 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Tue, 11 Jul 2023 11:07:27 +0000 Gerrit-HasComments: Yes
