Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20145 )
Change subject: IMPALA-12256: Fix DDLs losing create event ids in reloading partitions ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/20145/6/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/20145/6/tests/custom_cluster/test_events_custom_configs.py@846 PS6, Line 846: " delimited fields terminated by ','" % unique_database, > Can you add a few more comments to the test? I found it a bit confusing. If Sure. Added more comments. http://gerrit.cloudera.org:8080/#/c/20145/6/tests/custom_cluster/test_events_custom_configs.py@858 PS6, Line 858: for ddl in partition_ddls: : events_skipped_before = EventProcessorUtils.get_int_metric("events-skipped") : # Drop-create the partition and then runs a DDL on it. A DROP_PARTITION and an : # ADD_PARTITION event will be generated and should be skipped. The 3rd DDL might : # generate an ALTER_PART > Yeah, exactly. The key part is verifying no partitions will be added/droppe Added some comments for this. -- To view, visit http://gerrit.cloudera.org:8080/20145 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I052faa093bda69fb16db0d424c1478bba103dad9 Gerrit-Change-Number: 20145 Gerrit-PatchSet: 7 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Tue, 11 Jul 2023 12:26:27 +0000 Gerrit-HasComments: Yes
