Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/20145 )
Change subject: IMPALA-12256: Fix DDLs losing create event ids in reloading partitions ...................................................................... Patch Set 6: (1 comment) Thanks for the explanation Quanlong! I do not have other questions. :-) http://gerrit.cloudera.org:8080/#/c/20145/6/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/20145/6/tests/custom_cluster/test_events_custom_configs.py@858 PS6, Line 858: self.client.execute( : "alter table %s.part drop partition (p=0)" % unique_database) : self.client.execute( : "insert into %s.part partition(p=0) values (1),(2)" % unique_database) : self.client.execute(ddl) > > When we submit the 3 queries above to Impala, is it true that the order o Thanks for the detailed explanation Quanlong! :-) Now it's much clearer to me as to why "events-skipped" should be increased even in the case in which only the first DDL (ALTER TABLE DROP PARTITION) was finished when the event processor receives from HMS the corresponding DROP_PARTITION event. In such a case, 'hdfsPartition' within CatalogOpExecutor#canDropPartitionFromEvent() ( https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java#L4546) would be null and thus such a DROP_PARTITION event has to be skipped by the event processor. Thus, whether or not the 2nd DDL (INSERT INTO PARTITION) is finished when the DROP_PARTITION event is received, such an event will be skipped. -- To view, visit http://gerrit.cloudera.org:8080/20145 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I052faa093bda69fb16db0d424c1478bba103dad9 Gerrit-Change-Number: 20145 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Mon, 10 Jul 2023 02:25:20 +0000 Gerrit-HasComments: Yes
