Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20145 )
Change subject: IMPALA-12256: Fix DDLs losing create event ids in reloading partitions ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/20145/6/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/20145/6/tests/custom_cluster/test_events_custom_configs.py@858 PS6, Line 858: self.client.execute( : "alter table %s.part drop partition (p=0)" % unique_database) : self.client.execute( : "insert into %s.part partition(p=0) values (1),(2)" % unique_database) : self.client.execute(ddl) > When we submit the 3 queries above to Impala, is it true that the order of > the respective events received from HMS is non-deterministic? No, the order is deterministic. > What if we receive the DROP_PARTITION event prior to the events corresponding > to the other 2 queries? Will this DROP_PARTITION event be skipped in this > case? Or some logic ensures even in this case (the DROP_PARTITION event > arriving first) this DROP_PARTITION will still be skipped? We use a large polling interval (5s) in this test so it's more likely that event-processor fetched the events after the DDLs finish. Note that event-processor is scheduled in another independent thread. It's possible that it runs right after the first AlterTableDropPartition finishes and then gets the DROP_PARTITION event and processes it. In this case, the partition doesn't exist and the DROP_PARTITION event will be skipped as well. But the possibility is pretty small. In most of the cases, the event-processor will fetch events after these 3 DDLs finish. This test aims to verify that the DROP_PARTITION event is correctly skipped in this case. -- To view, visit http://gerrit.cloudera.org:8080/20145 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I052faa093bda69fb16db0d424c1478bba103dad9 Gerrit-Change-Number: 20145 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Sat, 08 Jul 2023 08:14:13 +0000 Gerrit-HasComments: Yes
