Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20735 )
Change subject: IMPALA-12580: Fix Iceberg predicate filtering skippedExpression calculation ...................................................................... Patch Set 1: (3 comments) Left some minor comments, otherwise the change LGTM. http://gerrit.cloudera.org:8080/#/c/20735/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20735/1//COMMIT_MSG@9 PS1, Line 9: et to In the commit messsage body the limit is 72 chars. http://gerrit.cloudera.org:8080/#/c/20735/1/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/20735/1/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@436 PS1, Line 436: /* nit: we usually use // for comments inside methods http://gerrit.cloudera.org:8080/#/c/20735/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-predicate-constant-propagation.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-predicate-constant-propagation.test: http://gerrit.cloudera.org:8080/#/c/20735/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-predicate-constant-propagation.test@24 PS1, Line 24: select col_a from ice_pred_const_prop where col_a = 1 and col_b = col_a and col_c = 1; You can repro this with an already existing table: select * from functional_parquet.iceberg_alltypes_part where i = 1 and p_int = i; Could you please add planner tests as well, so we can check the predicates in the plan tree? Could you please also add tests with more predicates? E.g.: select * from functional_parquet.iceberg_alltypes_part where i = 1 and p_bigint = 10 + i and p_int = p_bigint - 10; -- To view, visit http://gerrit.cloudera.org:8080/20735 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I692d3b186e5e73caf9c66ada4afbe36e49641952 Gerrit-Change-Number: 20735 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 28 Nov 2023 14:04:31 +0000 Gerrit-HasComments: Yes
