Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/20735 )
Change subject: IMPALA-12580: Fix Iceberg predicate filtering skippedExpression calculation ...................................................................... Patch Set 1: (2 comments) Thanks for the quick fix! http://gerrit.cloudera.org:8080/#/c/20735/1/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/20735/1/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@442 PS1, Line 442: skippedExpressions_ Should't the type of skippedExpressions be changed from Set<Expr> to List<Expr>? http://gerrit.cloudera.org:8080/#/c/20735/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-predicate-constant-propagation.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-predicate-constant-propagation.test: http://gerrit.cloudera.org:8080/#/c/20735/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-predicate-constant-propagation.test@7 PS1, Line 7: ('write.format.default' = 'parquet'); it's parquet by default, no need to set. -- To view, visit http://gerrit.cloudera.org:8080/20735 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I692d3b186e5e73caf9c66ada4afbe36e49641952 Gerrit-Change-Number: 20735 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 28 Nov 2023 15:24:37 +0000 Gerrit-HasComments: Yes
