Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20735 )
Change subject: IMPALA-12580: Fix Iceberg predicate filtering skippedExpression calculation ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Thanks for fixing this so quickly. I have one ask about e2e testing, otherwise the change LGTM! http://gerrit.cloudera.org:8080/#/c/20735/2/testdata/workloads/functional-planner/queries/PlannerTest/iceberg-predicates.test File testdata/workloads/functional-planner/queries/PlannerTest/iceberg-predicates.test: http://gerrit.cloudera.org:8080/#/c/20735/2/testdata/workloads/functional-planner/queries/PlannerTest/iceberg-predicates.test@172 PS2, Line 172: select p_int from functional_parquet.iceberg_alltypes_part where i = 1 and p_int = i; Maybe we could add the same tests as e2e tests as well, so we also check the results. -- To view, visit http://gerrit.cloudera.org:8080/20735 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I692d3b186e5e73caf9c66ada4afbe36e49641952 Gerrit-Change-Number: 20735 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 29 Nov 2023 12:42:22 +0000 Gerrit-HasComments: Yes
