Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/20735 )
Change subject: IMPALA-12580: Fix Iceberg predicate filtering skippedExpression calculation ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Just one nit. I'm fine with the patch anyway, but let's wait for Zoli to take a look. http://gerrit.cloudera.org:8080/#/c/20735/2/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/20735/2/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@452 PS2, Line 452: return skippedExpressions_; nit: I think this now fits into the same line as the 'if' -- To view, visit http://gerrit.cloudera.org:8080/20735 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I692d3b186e5e73caf9c66ada4afbe36e49641952 Gerrit-Change-Number: 20735 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 29 Nov 2023 11:59:20 +0000 Gerrit-HasComments: Yes
