Peter Rozsa has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/20735 )
Change subject: IMPALA-12580: Fix Iceberg predicate filtering skippedExpression calculation ...................................................................... IMPALA-12580: Fix Iceberg predicate filtering skippedExpression calculation This patch changes the collection method of skipped expressions from toSet to toList. toSet uses HashSet, which calls hashCode for expression nodes, which is not always applicable because expressions recreated by constant propagation have no id (null) and the default hashCode implementation for Expr requires it. Change-Id: I692d3b186e5e73caf9c66ada4afbe36e49641952 --- M fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java M testdata/workloads/functional-planner/queries/PlannerTest/iceberg-predicates.test M testdata/workloads/functional-query/queries/QueryTest/iceberg-query.test 3 files changed, 73 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/20735/3 -- To view, visit http://gerrit.cloudera.org:8080/20735 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I692d3b186e5e73caf9c66ada4afbe36e49641952 Gerrit-Change-Number: 20735 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
