Dan Hecht has posted comments on this change. Change subject: Add the query handle to error messages for Invalid Query Handle for beeswax interface. ......................................................................
Patch Set 1: > I was going to do that but I wasn't sure how to test the HS2 code > path. Also, is looks like there is more conversion to do on the > HS2 query handle, looks like it is stored as bytes and the output > should most likely be a hex UUID. We wouldn't want to output the > secret part of the handle I am guessing. > > Was considering using boost::spirit::karma for that but this > doesn't seem to be a common theme in the code yet (it should be - > it's rather fast). The query_id is the non-secret part, which you'll already have in TUniqueId format. See various places in impala-hs2-server.cc (Also note that we don't actually generate secret -- see ImpalaServer::ExecuteStatement() in impala-hs2-server.cc.) As far as testing, unfortunately our tests still use beeswax for the most part. But we do have some tests that use hs2 in tests/hs2 -- To view, visit http://gerrit.cloudera.org:8080/5748 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc113b3673e1b90f81e80e841740b8006bfd31ba Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden <zams...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-HasComments: No
