Matthew Jacobs has posted comments on this change. Change subject: IMPALA-1575: Yield admission control resources at query end ......................................................................
Patch Set 1: (7 comments) I think there were going to be some functional tests? http://gerrit.cloudera.org:8080/#/c/7079/1//COMMIT_MSG Commit Message: PS1, Line 12: query is finished query has transitioned to a state in which it will no longer return any more rows. PS1, Line 17: and an error PS1, Line 18: ended cancelled Line 19: 3. The query reaches eos (or the DML completes) Also: The query is cancelled by a client but not closed. (E.g. call HS2::CancelOperation() but not HS2::CloseOperation()) PS1, Line 22: complete avoid this word, e.g. use the wording I suggested above Line 24: call out the limitations, i.e. this doesn't mean all backends have completed terminated, and while this is already possible today, this can make this scenario more likely. Line 25: Change-Id: Ia5003d017b3142a160bacf7e3569ff26026b1700 comment on testing? I assume we still need to do the cluster testing. -- To view, visit http://gerrit.cloudera.org:8080/7079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5003d017b3142a160bacf7e3569ff26026b1700 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
