Marcel Kornacker has posted comments on this change. Change subject: IMPALA-1575: Yield admission control resources at query end ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7079/1/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: Line 1114: } > Does Coordinator::ReleaseResources() really mean that all finstances' resou you could view the admission control "tokens" as a resource, ie, there's a finite amount of it and it's accounted for. but the comment is a bit misleading, since the admission controller doesn't allocate actual compute resources. ReleaseResources() doesn't have any control over the instance resources. -- To view, visit http://gerrit.cloudera.org:8080/7079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5003d017b3142a160bacf7e3569ff26026b1700 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
