Joe McDonnell has posted comments on this change. Change subject: IMPALA-1575: Yield admission control resources at query end ......................................................................
Patch Set 1: Testing shows that the current approach doesn't work for mem_limit based admission control. The reserved memory is not released at the new location, so TestAdmissionControllerStress::test_mem_limit fails. >From what I can tell, the reserved memory is released when >QueryState::ReleaseResources is called. The codepath that calls this is >ImpalaServer::UnregisterQuery-> ClientRequestState::~ClientRequestState -> >Coordinator::~Coordinator -> QueryExecManager::ReleaseQueryState. -- To view, visit http://gerrit.cloudera.org:8080/7079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5003d017b3142a160bacf7e3569ff26026b1700 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-HasComments: No
