Dan Hecht has posted comments on this change. Change subject: IMPALA-1575: Yield admission control resources at query end ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7079/1/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: PS1, Line 889: WaitForBackendCompletion()) note that on this path we are waiting for all backends to finish already. Line 1114: } Does Coordinator::ReleaseResources() really mean that all finstances' resources have been freed? My interpretation was that this method was only for freeing resources for the coordinator object itself, and so I don't see why it makes sense tie admission control to it. -- To view, visit http://gerrit.cloudera.org:8080/7079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5003d017b3142a160bacf7e3569ff26026b1700 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
