Bikramjeet Vig has posted comments on this change.
Change subject: IMPALA-5602: Fix kudu queries being incorrectly optimized as
small query
......................................................................
Patch Set 2:
> Do you have a test for the case when the table is missing stats? I
> think there may be a similar bug in MaxRowsProcessedVisitor for
> that case:
>
>
> if (scan.isAccessingCollectionType()
> || (missingStats && !(scan.hasLimit() && scan.getConjuncts().isEmpty())))
> {
Good catch! fixed this in the latest patch as well
Thanks
--
To view, visit http://gerrit.cloudera.org:8080/7560
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I93822d67ebda41d5d0456095c429e3915a3f40c4
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bikramjeet Vig <[email protected]>
Gerrit-Reviewer: Bikramjeet Vig <[email protected]>
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: No
