Tim Armstrong has posted comments on this change. Change subject: IMPALA-5602: Fix query optimization for kudu and datasource tables ......................................................................
Patch Set 4: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/7560/4/tests/query_test/test_queries.py File tests/query_test/test_queries.py: Line 165: # that rely on it nit: missing . Line 166: del vector.get_value('exec_option')['exec_single_node_rows_threshold'] I think this is modifying the vector in-place. I.e. the change can leak out to other places. I'm not a py.test expert but we definitely copy the vector in other places to avoid this problem. -- To view, visit http://gerrit.cloudera.org:8080/7560 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93822d67ebda41d5d0456095c429e3915a3f40c4 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
