Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-5602: Fix query optimization for kudu and datasource tables ......................................................................
Patch Set 3: (13 comments) http://gerrit.cloudera.org:8080/#/c/7560/4/fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java File fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java: Line 367 > formatting Done http://gerrit.cloudera.org:8080/#/c/7560/3/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java File fe/src/main/java/org/apache/impala/planner/KuduScanNode.java: Line 527: return !kuduConjuncts_.isEmpty(); > nit oneline Done http://gerrit.cloudera.org:8080/#/c/7560/3/fe/src/main/java/org/apache/impala/planner/ScanNode.java File fe/src/main/java/org/apache/impala/planner/ScanNode.java: PS3, Line 219: (){ > nit: missing space Done PS3, Line 219: (){ > You are correct, that should be fixed as well. Done Line 219: public boolean hasPushedConjuncts(){ > I think DataSourceScanNode can also push conjuncts. Done http://gerrit.cloudera.org:8080/#/c/7560/4/testdata/workloads/functional-query/queries/QueryTest/data-source-tables.test File testdata/workloads/functional-query/queries/QueryTest/data-source-tables.test: PS4, Line 138: > can you put the full key here, i.e. + "(non default)" or whatever? That way adding "(non default)" for now. Will switch to whatever we decide to add in IMPALA-5784 for representing changes made by planner. http://gerrit.cloudera.org:8080/#/c/7560/3/tests/query_test/test_kudu.py File tests/query_test/test_kudu.py: Line 1007: def test_missing_table_stats(self, cursor, kudu_client, unique_database): > This needs @SkipIfNotHdfsMinicluster.plans since it's assuming a 3 node min Done PS3, Line 1019: self.client.execute("set explain_level=3") > you can actually use client.set_configuration(config_map) Done PS3, Line 1024: assert str(result).find("hosts=3 instances=3") != -1 > the more python-y way to say this is Done http://gerrit.cloudera.org:8080/#/c/7560/4/tests/query_test/test_kudu.py File tests/query_test/test_kudu.py: PS4, Line 1005: > creating a table. Done PS4, Line 1010: k > JIRA number: Done http://gerrit.cloudera.org:8080/#/c/7560/4/tests/query_test/test_queries.py File tests/query_test/test_queries.py: Line 165: > nit: missing . Done Line 166: def test_distinct_estimate(self, vector): > I think this is modifying the vector in-place. I.e. the change can leak out I tried running all tests in this class to check for this and it seems the changes to the vector do not carry on to other tests. -- To view, visit http://gerrit.cloudera.org:8080/7560 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93822d67ebda41d5d0456095c429e3915a3f40c4 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
